When you can no longer pass the physical (2nd Class min.) Other than that there will be a bias against hiring a pilot over 50 years of age. However, I think that it's comforting to sit next to an instructor that's old enough to be my dad! Gray hairs on the teacher don't hurt the confidence of the new student.